pl011: cnds: cbmem: 16550: Fix comments
authorAntonio Nino Diaz <[email protected]>
Mon, 8 Oct 2018 12:26:48 +0000 (13:26 +0100)
committerAntonio Nino Diaz <[email protected]>
Fri, 12 Oct 2018 13:47:41 +0000 (14:47 +0100)
The comments with the prototypes of the register functions of the
console drivers are incorrect. The arguments are wrong. This patch fixes
them.

Change-Id: I38c4b481ee69e840780111c42f03c0752eb6315c
Signed-off-by: Antonio Nino Diaz <[email protected]>
drivers/arm/pl011/aarch32/pl011_console.S
drivers/arm/pl011/aarch64/pl011_console.S
drivers/cadence/uart/aarch64/cdns_console.S
drivers/coreboot/cbmem_console/aarch64/cbmem_console.S
drivers/ti/uart/aarch64/16550_console.S

index b7892e12e14eda6cb98e5db841d076c61d69c643..841ea446c7930b9bfb7493dc8a543d3b0d334857 100644 (file)
@@ -89,8 +89,9 @@ endfunc console_pl011_core_init
        .globl console_pl011_register
 
        /* -------------------------------------------------------
-        * init console_pl011_register(console_pl011_t *console,
-        *      uintptr_t base, uint32_t clk, uint32_t baud)
+        * int console_pl011_register(uintptr_t baseaddr,
+        *     uint32_t clock, uint32_t baud,
+        *     console_pl011_t *console);
         * Function to initialize and register a new PL011
         * console. Storage passed in for the console struct
         * *must* be persistent (i.e. not from the stack).
index 448501a22be7138e64fa156a65a2b0b79ece81eb..d6a2d6b89950663015f9c63a21bd111f8b89eeef 100644 (file)
@@ -85,8 +85,9 @@ endfunc console_pl011_core_init
        .globl console_pl011_register
 
        /* -----------------------------------------------
-        * int console_pl011_register(console_pl011_t *console,
-               uintptr_t base, uint32_t clk, uint32_t baud)
+        * int console_pl011_register(uintptr_t baseaddr,
+        *     uint32_t clock, uint32_t baud,
+        *     console_pl011_t *console);
         * Function to initialize and register a new PL011
         * console. Storage passed in for the console struct
         * *must* be persistent (i.e. not from the stack).
index 6732631970792166c649ae414d9ba6f247d4ee2e..71359a6d2006cfff21b428dd2045b801e1ff908f 100644 (file)
@@ -54,8 +54,9 @@ endfunc console_cdns_core_init
        .globl console_cdns_register
 
        /* -----------------------------------------------
-        * int console_cdns_register(console_cdns_t *console,
-               uintptr_t base, uint32_t clk, uint32_t baud)
+        * int console_cdns_register(uint64_t baseaddr,
+        *     uint32_t clock, uint32_t baud,
+        *     console_cdns_t *console);
         * Function to initialize and register a new CDNS
         * console. Storage passed in for the console struct
         * *must* be persistent (i.e. not from the stack).
index 2fc06033495020c8523d3f143bb370984dd56d13..184853d9d91a528f24ea685f1d754e2a09a99117 100644 (file)
@@ -19,8 +19,8 @@
        .globl console_cbmc_flush
 
        /* -----------------------------------------------
-        * int console_cbmc_register(console_cbmc_t *console,
-        *                           uintptr_t base)
+        * int console_cbmc_register(uintptr_t base,
+        *                           console_cbmc_t *console);
         * Registers a new CBMEM console instance. Reads
         * the size field from the buffer header structure
         * and stores it in our console_cbmc_t struct, so
index d46fa61190e719e2d112190a2e974dfcddb27425..0f9a9d5764d13382448a7f05076c88c29e8f3b60 100644 (file)
@@ -87,8 +87,9 @@ endfunc console_16550_core_init
        .globl console_16550_register
 
        /* -----------------------------------------------
-        * int console_16550_register(console_16550_t *console,
-               uintptr_t base, uint32_t clk, uint32_t baud)
+        * int console_16550_register(uintptr_t baseaddr,
+        *     uint32_t clock, uint32_t baud,
+        *     console_16550_t *console);
         * Function to initialize and register a new 16550
         * console. Storage passed in for the console struct
         * *must* be persistent (i.e. not from the stack).